Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only retry when receiving a 429 status code #13523

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

kruskall
Copy link
Member

Motivation/summary

The only safe status code to retry is 429 because it guarantee that the document has not been indexed. Everything else might create duplicate documents

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
The only safe status code to retry is 429 because it guarantee that the
document has not been indexed. Everything else might create duplicate documents
@kruskall kruskall requested a review from a team as a code owner June 28, 2024 15:12
Copy link
Contributor

mergify bot commented Jun 28, 2024

This pull request does not have a backport label. Could you fix it @kruskall? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Jun 28, 2024
Copy link
Member

@carsonip carsonip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this likely warrants a changelog

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@kruskall kruskall merged commit b6626d7 into elastic:main Jul 16, 2024
10 checks passed
@kruskall kruskall deleted the fix/retry-429 branch July 16, 2024 22:33
@kruskall kruskall mentioned this pull request Oct 21, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants