Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: specify correct path for tools/go.mod when running benchmark #13639

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

kyungeunni
Copy link
Contributor

Motivation/summary

Benchmark fails with the following error message:

go: open tools/go.mod: no such file or directory
cat: write error: Broken pipe

This is caused by specifying the wrong path for the target file; the working directory is apm-server/testing/apmbenech and the target file is in apm-server/tools/go.mod

make[1]: Entering directory '/home/runner/work/apm-server/apm-server/testing/benchmark'

fix it by specifying the correct path for the tools/go.mod file by using GITROOT:

GITROOT ?= $(shell git rev-parse --show-toplevel)

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues

Introduced by https://github.com/elastic/apm-server/pull/13421/files

@kyungeunni kyungeunni requested a review from a team as a code owner July 9, 2024 03:23
Copy link
Contributor

mergify bot commented Jul 9, 2024

This pull request does not have a backport label. Could you fix it @kyungeunni? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Jul 9, 2024
@kyungeunni kyungeunni changed the title fix: specify correct path for tools/go.mod fix: specify correct path for tools/go.mod when running benchmark Jul 9, 2024
@kyungeunni kyungeunni merged commit 3f16a76 into elastic:main Jul 9, 2024
10 checks passed
@kyungeunni kyungeunni deleted the fix-path-for-bench branch July 9, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants