Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test agentcfg es fetcher scroll id #13959

Merged
merged 2 commits into from
Sep 3, 2024
Merged

Test agentcfg es fetcher scroll id #13959

merged 2 commits into from
Sep 3, 2024

Conversation

carsonip
Copy link
Member

@carsonip carsonip commented Aug 30, 2024 •
edited
Loading

Motivation/summary

Follow up on #13958 to add test. Backporting to 8.15 as this should be considered as part of the bugfix. Rebase after #13958 merges.

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues

@carsonip carsonip requested a review from a team as a code owner August 30, 2024 12:34
@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 30, 2024

This pull request does not have a backport label. Could you fix it @carsonip? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Aug 30, 2024
@carsonip carsonip added backport-8.15 Automated backport with mergify and removed backport-skip Skip notification from the automated backport with mergify labels Aug 30, 2024
@carsonip carsonip mentioned this pull request Sep 2, 2024
Merged
2 tasks
@carsonip carsonip merged commit 2aec4d1 into elastic:main Sep 3, 2024
11 checks passed
mergify bot pushed a commit that referenced this pull request Sep 3, 2024
@carsonip @mergify
Test agentcfg es fetcher scroll id (#13959)
a9af3c0 
Follow up on #13958 to add test

(cherry picked from commit 2aec4d1)
@mergify mergify bot mentioned this pull request Sep 3, 2024
Merged
2 tasks
carsonip added a commit that referenced this pull request Sep 9, 2024
@carsonip
Test agentcfg es fetcher scroll id (#13959)
b4017b6 
Follow up on #13958 to add test

(cherry picked from commit 2aec4d1)
mergify bot added a commit that referenced this pull request Sep 9, 2024
@mergify @carsonip
Test agentcfg es fetcher scroll id (#13959) (#13987)
91bef75 
Follow up on #13958 to add test

(cherry picked from commit 2aec4d1)

Co-authored-by: Carson Ip <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marclop marclop marclop approved these changes

Assignees
No one assigned
Labels
backport-8.15 Automated backport with mergify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carsonip @marclop