Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Add parallel monitoring middleware test #14443

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

1pkg
Copy link
Member

@1pkg 1pkg commented Oct 24, 2024

Motivation/summary

This PR adds concurrency test for the fix from #14335.

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Test results from v8.15.2

=== RUN   TestMonitoringHandler
=== RUN   TestMonitoringHandler/Parallel
==================
WARNING: DATA RACE
Read at 0x00c000127050 by goroutine 24:
  runtime.mapassign_fast64ptr()
 ...
 ...
 ...

Previous write at 0x00c000127050 by goroutine 23:
  runtime.mapaccess2_faststr()
 ...
 ...
 ...

Goroutine 24 (running) created at:
 ...
 ...
 ...

Goroutine 23 (finished) created at:
 ...
 ...
 ...
==================

Test results from main

=== RUN   TestMonitoringHandler
=== RUN   TestMonitoringHandler/Parallel
--- PASS: TestMonitoringHandler (0.00s)
    --- PASS: TestMonitoringHandler/Parallel (0.00s)
PASS
ok  	github.com/elastic/apm-server/internal/beater/middleware	1.547s

Related issues

#14335

@1pkg 1pkg added backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify labels Oct 24, 2024
@1pkg 1pkg self-assigned this Oct 24, 2024
@1pkg 1pkg requested a review from a team as a code owner October 24, 2024 21:53
@1pkg 1pkg mentioned this pull request Oct 24, 2024
11 tasks
@1pkg 1pkg merged commit b54be36 into main Oct 25, 2024
11 checks passed
@1pkg 1pkg deleted the add-monitoring-middleware-concurrency-tests branch October 25, 2024 05:35
mergify bot pushed a commit that referenced this pull request Oct 25, 2024
mergify bot pushed a commit that referenced this pull request Oct 25, 2024
mergify bot added a commit that referenced this pull request Oct 25, 2024
(cherry picked from commit b54be36)

Co-authored-by: Kostiantyn Masliuk <[email protected]>
mergify bot added a commit that referenced this pull request Oct 25, 2024
(cherry picked from commit b54be36)

Co-authored-by: Kostiantyn Masliuk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants