Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unnecessary ristretto replace #14828

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

kruskall
Copy link
Member

@kruskall kruskall commented Dec 4, 2024

Motivation/summary

we dropped jaeger and beats is using ristretto/v2.
the only lib using ristretto v1 is badger v2 so we can drop the replace directive

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues

Related to #11546

we dropped jaeger and beats is using ristretto/v2.
the only lib using ristretto v1 is badger v2 so we can
drop the replace directive
@kruskall kruskall added the backport-skip Skip notification from the automated backport with mergify label Dec 4, 2024
@kruskall kruskall requested a review from a team as a code owner December 4, 2024 19:19
@kruskall kruskall enabled auto-merge (squash) December 5, 2024 08:52
@kruskall kruskall merged commit da8716e into elastic:main Dec 5, 2024
11 checks passed
@kruskall kruskall deleted the refactor/cleanup-ristretto-replace branch December 5, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants