Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TF_VAR_apm_server_tail_sampling for scheduled gh actions #15003

Merged
merged 3 commits into from
Dec 19, 2024

Conversation

carsonip
Copy link
Member

@carsonip carsonip commented Dec 19, 2024

Motivation/summary

A regression from #14985 causing nightly benchmark to fail.

The root cause of regression was that scheduled GH actions ignore workflow_dispatch defaults.

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues

@carsonip carsonip requested a review from a team as a code owner December 19, 2024 17:13
Copy link
Contributor

mergify bot commented Dec 19, 2024

This pull request does not have a backport label. Could you fix it @carsonip? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • backport-8.x is the label to automatically backport to the 8.x branch.

Copy link
Contributor

mergify bot commented Dec 19, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Dec 19, 2024
@carsonip carsonip marked this pull request as draft December 19, 2024 17:14
marclop
marclop previously approved these changes Dec 19, 2024
@carsonip carsonip marked this pull request as ready for review December 19, 2024 17:25
@carsonip carsonip requested a review from marclop December 19, 2024 17:25
@carsonip carsonip changed the title Fix bad TF_VAR_apm_server_tail_sampling in gh actions Fix TF_VAR_apm_server_tail_sampling for scheduled gh actions Dec 19, 2024
@carsonip carsonip enabled auto-merge (squash) December 19, 2024 17:26
Copy link
Contributor

@marclop marclop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, and 💯 CI benchmarking karma points for fixing it

@carsonip carsonip merged commit 7c1b706 into elastic:main Dec 19, 2024
11 checks passed
mergify bot pushed a commit that referenced this pull request Dec 19, 2024
A regression from #14985 causing nightly benchmark to fail.

(cherry picked from commit 7c1b706)
mergify bot added a commit that referenced this pull request Dec 19, 2024
…#15004)

A regression from #14985 causing nightly benchmark to fail.

(cherry picked from commit 7c1b706)

Co-authored-by: Carson Ip <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants