-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TF_VAR_apm_server_tail_sampling for scheduled gh actions #15003
Fix TF_VAR_apm_server_tail_sampling for scheduled gh actions #15003
Conversation
This pull request does not have a backport label. Could you fix it @carsonip? 🙏
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix, and 💯 CI benchmarking karma points for fixing it
…#15004) A regression from #14985 causing nightly benchmark to fail. (cherry picked from commit 7c1b706) Co-authored-by: Carson Ip <[email protected]>
Motivation/summary
A regression from #14985 causing nightly benchmark to fail.
The root cause of regression was that scheduled GH actions ignore
workflow_dispatch
defaults.Checklist
For functional changes, consider:
How to test these changes
Related issues