Use more inclusive language #3903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove use of "whitelist" and "blacklist". I have not changed the testdata (sourcemaps), nor the docs copied from beats. The latter should be changed upstream.
|
@bmorelli25 there's a very minor change to docs here, could you please take a quick glance? |
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
simitt
approved these changes
Jun 18, 2020
Codecov Report
@@ Coverage Diff @@
## master #3903 +/- ##
=======================================
Coverage 79.74% 79.74%
=======================================
Files 137 137
Lines 6239 6239
=======================================
Hits 4975 4975
Misses 1264 1264 |
graphaelli
approved these changes
Jun 18, 2020
axw
added a commit
to axw/apm-server
that referenced
this pull request
Jul 1, 2020
Remove use of "whitelist" and "blacklist". I have not changed the testdata (sourcemaps), nor the docs copied from beats. The latter should be changed upstream.
axw
added a commit
that referenced
this pull request
Jul 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Remove use of "whitelist" and "blacklist".
I have not changed the testdata (sourcemaps), nor the docs copied from beats. The latter should be changed upstream.
Checklist
- [ ] I have updated CHANGELOG.asciidocI have considered changes for:
- [ ] logging (add log lines, choose appropriate log selector, etc.)- [ ] metrics and monitoring (create issue for Kibana team to add metrics to visualizations, e.g. Kibana#44001)- [ ] telemetry- [ ] Elasticsearch Service (https://cloud.elastic.co)- [ ] Elastic Cloud Enterprise (https://www.elastic.co/products/ece)- [ ] Elastic Cloud on Kubernetes (https://www.elastic.co/elastic-cloud-kubernetes)How to test these changes
make testRelated issues
#3896