-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add required privileges for using API Keys #4130
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axw
approved these changes
Sep 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a few minor things.
Co-authored-by: Andrew Wilkins <[email protected]>
bmorelli25
commented
Sep 3, 2020
axw
reviewed
Sep 9, 2020
By default, `enabled` is set to `false`, and API key support is disabled. | ||
|
||
TIP: Not using Elastic APM agents? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice 👍
bmorelli25
added a commit
to bmorelli25/apm-server
that referenced
this pull request
Sep 9, 2020
Co-authored-by: Andrew Wilkins <[email protected]>
bmorelli25
added a commit
to bmorelli25/apm-server
that referenced
this pull request
Sep 9, 2020
Co-authored-by: Andrew Wilkins <[email protected]>
bmorelli25
added a commit
that referenced
this pull request
Sep 9, 2020
Co-authored-by: Andrew Wilkins <[email protected]>
bmorelli25
added a commit
that referenced
this pull request
Sep 9, 2020
Co-authored-by: Andrew Wilkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
This PR adds the required privileges for using API keys. Previously, we didn't do a good job of calling out the
manage_api_cluster
privilege, or of providing an example of how to setapm
application privileges.This PR adds an example workflow for creating an API key using the ES create API key API. The process used is these docs was originally documented here.
Server CLI tested with:
ES version tested with:
Related issues
Closes #3566.
Closes #4135.
Additional work
After this PR is approved, a separate PR will need to be opened in the Beats repo to persist these changes: elastic/beats#20911