docs: Update field ref with ECS icon #4272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
|
Sounds right. You could bundle a |
Neat, thanks. That worked! |
bmorelli25
added a commit
to bmorelli25/apm-server
that referenced
this pull request
Oct 7, 2020
bmorelli25
added a commit
to bmorelli25/apm-server
that referenced
this pull request
Oct 7, 2020
# Conflicts: # docs/fields.asciidoc
bmorelli25
added a commit
to bmorelli25/apm-server
that referenced
this pull request
Oct 7, 2020
bmorelli25
added a commit
that referenced
this pull request
Oct 7, 2020
bmorelli25
added a commit
that referenced
this pull request
Oct 7, 2020
bmorelli25
added a commit
that referenced
this pull request
Oct 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
I updated
generate_fields_docs.pyin elastic/beats#21359 to include an ECS icon next to ECS fields in the field reference documentation. This PR makes use of that new script to create APM Server's field reference:make updateto update the field referenceUnfortunately, I can't getmake updateto make use of that change. I still have to use a local clone of Beats to get things to work:go mod edit -replace=github.com/elastic/beats/v7=../beatsIs this because APM Server needs to update to a later version of Beats before we can make use of this change? If so, does it make more sense to wait on this PR until after that happens?Related issues
Closes elastic/apm#276.
Relates to elastic/beats#20729.