-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
store navigationTiming marks as scaled floats #915
store navigationTiming marks as scaled floats #915
Conversation
2efea2b
to
623ade8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for a short term solution.
As transaction.marks
can hold all kinds of objects we should investigate how we can enable this for whatever values are sent in the future.
are we waiting for something to merge this? |
I should have written it up here, sorry. Per @simitt's comment, I could not confirm that this change doesn't affect other objects under |
623ade8
to
571ac0e
Compare
@@ -119,6 +119,10 @@ | |||
}, | |||
"id": "945254c5-67a5-417e-8a4e-aa29efcbfb79", | |||
"marks": { | |||
"another_mark": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to run approvals again, these are now called some_long
some_float
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, done
c5c2bf8
to
03834a5
Compare
03834a5
to
860e3ea
Compare
* store navigationTiming marks as scaled floats * test that navigationTiming marks are the only ones impacted
* store navigationTiming marks as scaled floats * test that navigationTiming marks are the only ones impacted
* store navigationTiming marks as scaled floats * test that navigationTiming marks are the only ones impacted
for #708. Amends the elasticsearch mapping template to include:
Given this event:
the current elasticsearch mapping would be:
with this change, the mapping ends up:
This is a special case update to store
navigationTiming
s.