Remove keep_state flag

elastic · Oct 27, 2020 · 07db56f · 07db56f
1 parent f32ba51
commit 07db56f
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 31 deletions.
diff --git a/CHANGELOG.next.asciidoc b/CHANGELOG.next.asciidoc
@@ -640,7 +640,7 @@ https://github.com/elastic/beats/compare/v7.0.0-alpha2...master[Check the HEAD d
 - Adding support for FIPS in s3 input {pull}21446[21446]
 - Add SSL option to checkpoint module {pull}19560[19560]
 - Add max_number_of_messages config into s3 input. {pull}21993[21993]
-- Add optional settings to Okta to preserve state between restarts {pull}22091[22091]
+- Update Okta documentation for new stateful restarts. {pull}22091[22091]
 
 *Heartbeat*
 

diff --git a/filebeat/docs/modules/okta.asciidoc b/filebeat/docs/modules/okta.asciidoc
@@ -93,20 +93,9 @@ information.
       supported_protocols: [TLSv1.2]
 ----
 
-*`var.keep_state`*::
-
-By default, this module does not persist the timestamp of the last read event. When you restart the module will read events from the beginning of the
-log. To minimize duplicates documents the module uses the event's Okta UUID
-value as the Elasticsearch `_id`. To use the last read event timestamp between restarts, `var.keep_state` can be set to `true`. It defaults to `false`.
-+
-[source,yaml]
-----
-    var.keep_state: true
-----
-
 *`var.initial_interval`*::
 
-When `var.keep_state` is set to `true`, an initial interval can be defined. The first time the module starts, will fetch events from the current moment minus the initial interval value. It defaults to `24h`.
+An initial interval can be defined. The first time the module starts, will fetch events from the current moment minus the initial interval value. Following restarts will fetch events starting from the last event read. It defaults to `24h`.
 +
 [source,yaml]
 ----

diff --git a/x-pack/filebeat/module/okta/_meta/docs.asciidoc b/x-pack/filebeat/module/okta/_meta/docs.asciidoc
@@ -88,20 +88,9 @@ information.
       supported_protocols: [TLSv1.2]
 ----
 
-*`var.keep_state`*::
-
-By default, this module does not persist the timestamp of the last read event. When you restart the module will read events from the beginning of the
-log. To minimize duplicates documents the module uses the event's Okta UUID
-value as the Elasticsearch `_id`. To use the last read event timestamp between restarts, `var.keep_state` can be set to `true`. It defaults to `false`.
-+
-[source,yaml]
-----
-    var.keep_state: true
-----
-
 *`var.initial_interval`*::
 
-When `var.keep_state` is set to `true`, an initial interval can be defined. The first time the module starts, will fetch events from the current moment minus the initial interval value. It defaults to `24h`.
+An initial interval can be defined. The first time the module starts, will fetch events from the current moment minus the initial interval value. Following restarts will fetch events starting from the last event read. It defaults to `24h`.
 +
 [source,yaml]
 ----

diff --git a/x-pack/filebeat/module/okta/system/config/input.yml b/x-pack/filebeat/module/okta/system/config/input.yml
@@ -44,13 +44,9 @@ ssl: {{ .ssl | tojson }}
 url: {{ .url }}
 {{ end }}
 
-{{ if .keep_state }}
 date_cursor.field: published
 date_cursor.url_field: since
-  {{ if .initial_interval }}
 date_cursor.initial_interval: {{ .initial_interval }}
-  {{ end }}
-{{ end }}
 
 {{ else if eq .input "file" }}
 

diff --git a/x-pack/filebeat/module/okta/system/manifest.yml b/x-pack/filebeat/module/okta/system/manifest.yml
@@ -32,8 +32,6 @@ var:
   - name: tags
     default: [forwarded]
   - name: url
-  - name: keep_state
-    default: false
   - name: initial_interval
     default: 24h