Make processor available to all Beats

I moved the processor to libbeat to make it available to all Beats. And because it's not available to all Beats it now makes sense to include the docs by default in all Beats.
elastic · Feb 25, 2020 · 63c5787 · 63c5787
1 parent ecba36c
commit 63c5787
Show file tree

Hide file tree

Showing 8 changed files with 8 additions and 7 deletions.
diff --git a/libbeat/cmd/instance/imports_common.go b/libbeat/cmd/instance/imports_common.go
@@ -35,5 +35,6 @@ import (
 	_ "github.com/elastic/beats/libbeat/processors/extract_array"
 	_ "github.com/elastic/beats/libbeat/processors/fingerprint"
 	_ "github.com/elastic/beats/libbeat/processors/registered_domain"
+	_ "github.com/elastic/beats/libbeat/processors/translate_sid"
 	_ "github.com/elastic/beats/libbeat/publisher/includes" // Register publisher pipeline modules
 )
diff --git a/libbeat/docs/processors-list.asciidoc b/libbeat/docs/processors-list.asciidoc
@@ -95,7 +95,7 @@ endif::[]
 ifndef::no_truncate_fields_processor[]
 * <<truncate-fields, `truncate_fields`>>
 endif::[]
-ifdef::include_translate_sid_processor[]
+ifdef::no_translate_sid_processor[]
 * <<processor-translate-sid, `translate_sid`>>
 endif::[]
 //# end::processors-list[]
@@ -194,8 +194,8 @@ endif::[]
 ifndef::no_truncate_fields_processor[]
 include::{libbeat-processors-dir}/actions/docs/truncate_fields.asciidoc[]
 endif::[]
-ifdef::include_translate_sid_processor[]
-include::{winlogbeat-processors-dir}/translate_sid/docs/translate_sid.asciidoc[]
+ifdef::no_translate_sid_processor[]
+include::{libbeat-processors-dir}/translate_sid/docs/translate_sid.asciidoc[]
 endif::[]
 
 //# end::processors-include[]

diff --git a/...ogbeat/processors/translate_sid/config.go → libbeat/processors/translate_sid/config.go b/...ogbeat/processors/translate_sid/config.go → libbeat/processors/translate_sid/config.go
diff --git a/winlogbeat/processors/translate_sid/doc.go → libbeat/processors/translate_sid/doc.go b/winlogbeat/processors/translate_sid/doc.go → libbeat/processors/translate_sid/doc.go
diff --git a/...translate_sid/docs/translate_sid.asciidoc → ...translate_sid/docs/translate_sid.asciidoc b/...translate_sid/docs/translate_sid.asciidoc → ...translate_sid/docs/translate_sid.asciidoc
@@ -5,7 +5,8 @@ beta[]
 
 The `translate_sid` processor translates a Windows security identifier (SID)
 into an account name. It retrieves the name of the account associated with the
-SID, the first domain on which the SID is found, and the type of account.
+SID, the first domain on which the SID is found, and the type of account. This
+is only available on Windows.
 
 Every account on a network is issued a unique SID when the account is first
 created. Internal processes in Windows refer to an account's SID rather than

diff --git a/.../processors/translate_sid/translatesid.go → .../processors/translate_sid/translatesid.go b/.../processors/translate_sid/translatesid.go → .../processors/translate_sid/translatesid.go
@@ -15,7 +15,7 @@
 // specific language governing permissions and limitations
 // under the License.
 
-//+build windows
+// +build windows
 
 package translate_sid
 

diff --git a/...essors/translate_sid/translatesid_test.go → ...essors/translate_sid/translatesid_test.go b/...essors/translate_sid/translatesid_test.go → ...essors/translate_sid/translatesid_test.go
@@ -15,7 +15,7 @@
 // specific language governing permissions and limitations
 // under the License.
 
-//+build windows
+// +build windows
 
 package translate_sid
 

diff --git a/winlogbeat/cmd/root.go b/winlogbeat/cmd/root.go
@@ -29,7 +29,6 @@ import (
 	_ "github.com/elastic/beats/libbeat/processors/script"
 	_ "github.com/elastic/beats/libbeat/processors/timestamp"
 	_ "github.com/elastic/beats/winlogbeat/processors/script/javascript/module/winlogbeat"
-	_ "github.com/elastic/beats/winlogbeat/processors/translate_sid"
 )
 
 // Name of this beat