Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Heartbeat] Following redirects accumulates in redirects path #15941

Closed
andrewvc opened this issue Jan 29, 2020 · 2 comments · Fixed by #15959
Closed

[Heartbeat] Following redirects accumulates in redirects path #15941

andrewvc opened this issue Jan 29, 2020 · 2 comments · Fixed by #15959
Assignees
@andrewvc
Labels
blocker Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team v7.6.0

Comments

@andrewvc
Copy link
Contributor

andrewvc commented Jan 29, 2020 •
edited
Loading

The new redirects feature introduced in 7.6 via #15939 re-uses an array across requests for tracking the list of redirects. This list grows with each request, potentially using up tons of memory.
@andrewvc andrewvc added blocker Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team v7.6.0 labels Jan 29, 2020
@andrewvc andrewvc self-assigned this Jan 29, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/uptime (:uptime)

andrewvc added a commit to andrewvc/beats that referenced this issue Jan 29, 2020
@andrewvc
[Heartbeat] Fix accumulation/location of redirects
0524e27 
This patch fixes two issues:

1. Fixes: elastic#15941 . Each invoked check using redirects would add to the previous list of
2. The redirects should be in the `http.response.redirects` field, not
the `http.redirects` field  where they reside today. The docs and
mapping both indicate that `http.response.redirects` is the correct
place already.
redirects from the last check, resulting in huge arrays.
@andrewvc andrewvc mentioned this issue Jan 29, 2020
Merged
andrewvc added a commit that referenced this issue Jan 30, 2020
@andrewvc
[Heartbeat] Fix accumulation/location of redirects (#15944)
ba1a92f 
1. Fixes: #15941 . Each invoked check using redirects would add to the previous list of
2. The redirects should be in the `http.response.redirects` field, not
the `http.redirects` field  where they reside today. The docs and
mapping both indicate that `http.response.redirects` is the correct
place already.
redirects from the last check, resulting in huge arrays.
andrewvc added a commit to andrewvc/beats that referenced this issue Jan 30, 2020
@andrewvc
[Heartbeat] Fix accumulation/location of redirects (elastic#15944)
cd8fe1c 
1. Fixes: elastic#15941 . Each invoked check using redirects would add to the previous list of
2. The redirects should be in the `http.response.redirects` field, not
the `http.redirects` field  where they reside today. The docs and
mapping both indicate that `http.response.redirects` is the correct
place already.
redirects from the last check, resulting in huge arrays.

(cherry picked from commit ba1a92f)
@andrewvc andrewvc mentioned this issue Jan 30, 2020
Merged
andrewvc added a commit to andrewvc/beats that referenced this issue Jan 30, 2020
@andrewvc
[Heartbeat] Fix accumulation/location of redirects (elastic#15944)
581e1e6 
1. Fixes: elastic#15941 . Each invoked check using redirects would add to the previous list of
2. The redirects should be in the `http.response.redirects` field, not
the `http.redirects` field  where they reside today. The docs and
mapping both indicate that `http.response.redirects` is the correct
place already.
redirects from the last check, resulting in huge arrays.

(cherry picked from commit ba1a92f)
@andrewvc andrewvc mentioned this issue Jan 30, 2020
Merged
@andrewvc
Copy link
Contributor Author

Fixed in #15944

andrewvc added a commit that referenced this issue Jan 30, 2020
@andrewvc
[Heartbeat] Fix accumulation/location of redirects (#15944) (#15958)
c491867 
1. Fixes: #15941 . Each invoked check using redirects would add to the previous list of
2. The redirects should be in the `http.response.redirects` field, not
the `http.redirects` field  where they reside today. The docs and
mapping both indicate that `http.response.redirects` is the correct
place already.
redirects from the last check, resulting in huge arrays.

(cherry picked from commit ba1a92f)
andrewvc added a commit that referenced this issue Jan 30, 2020
@andrewvc
[Heartbeat] Fix accumulation/location of redirects (#15944) (#15959)
b1b319d 
1. Fixes: #15941 . Each invoked check using redirects would add to the previous list of
2. The redirects should be in the `http.response.redirects` field, not
the `http.redirects` field  where they reside today. The docs and
mapping both indicate that `http.response.redirects` is the correct
place already.
redirects from the last check, resulting in huge arrays.

(cherry picked from commit ba1a92f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewvc andrewvc

Labels
blocker Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team v7.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Heartbeat] Fix accumulation/location of redirects (#15944) andrewvc/beats
2 participants
@andrewvc @elasticmachine