Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Figure out if ECS logging is enabled when holding a logger instance #18815

Closed
simitt opened this issue May 28, 2020 · 1 comment
Closed

Figure out if ECS logging is enabled when holding a logger instance #18815

simitt opened this issue May 28, 2020 · 1 comment
Assignees
@simitt
Labels
Team:apm APM Server team issues/PRs

Comments

@simitt
Copy link
Contributor

simitt commented May 28, 2020

With #17974 we introduced a config setting to enable ECS logging. This adds the MVP of ECS keys to any log lines. It was only the first step towards ECS logging and requires more work in libbeat and other beats to be fully compliant with ECS. Enabling logging.ecs changes the log format, and therefore is opt-in. When holding a logger instance one needs to be able to distinguish whether or not ECS logging is enabled to avoid conflicting changes, e.g. changing a log key from url: "xxx" (string) to url.original: "xxx" }(url being an object).
@simitt simitt self-assigned this May 28, 2020
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 28, 2020
@simitt simitt added the Team:apm APM Server team issues/PRs label May 28, 2020
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label May 28, 2020
simitt added a commit to simitt/beats that referenced this issue May 28, 2020
@simitt
Add ECS information to logger instance
b55f705 
Derive information whether ECS logging is enabled from any
logger instance as requirement to make decisions about logging keys to
use.

closes elastic#18815
@simitt simitt mentioned this issue May 28, 2020
Closed
2 tasks
@simitt
Copy link
Contributor Author

simitt commented Aug 11, 2021

Closing this according to outcome of discussions in #18820 .

@simitt simitt closed this as completed Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simitt simitt

Labels
Team:apm APM Server team issues/PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add ECS information to logger instance simitt/beats
1 participant
@simitt