Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filebeat] Netflow input - convert to input API v2 #37865

Closed
andrewkroh opened this issue Feb 6, 2024 · 1 comment · Fixed by #37901
Closed

[Filebeat] Netflow input - convert to input API v2 #37865

andrewkroh opened this issue Feb 6, 2024 · 1 comment · Fixed by #37901
Assignees
Labels
enhancement Filebeat Filebeat Team:Security-Deployment and Devices Deployment and Devices Team in Security Solution

Comments

@andrewkroh
Copy link
Member

Describe the enhancement:

The netflow input should be converted to the v2 API in order to take advantage of the ability to control beat.Client configuration.

The "v2" API is defined at. The netflow input itself is a stateless (has no persistant state to store in a "cursor").

// Input is a configured input object that can be used to test or start
// the actual data collection.
type Input interface {
// Name reports the input name.
//
// XXX: check if/how we can remove this method. Currently it is required for
// compatibility reasons with existing interfaces in libbeat, autodiscovery
// and filebeat.
Name() string
// Test checks the configuration and runs additional checks if the Input can
// actually collect data for the given configuration (e.g. check if host/port or files are
// accessible).
Test(TestContext) error
// Run starts the data collection. Run must return an error only if the
// error is fatal making it impossible for the input to recover.
Run(Context, beat.PipelineConnector) error
}

@andrewkroh andrewkroh added enhancement Filebeat Filebeat Team:Security-Deployment and Devices Deployment and Devices Team in Security Solution labels Feb 6, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Filebeat Filebeat Team:Security-Deployment and Devices Deployment and Devices Team in Security Solution
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants