Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filebeat] Netflow input - disable event normalization #37764

Closed
andrewkroh opened this issue Jan 26, 2024 · 5 comments · Fixed by #37901 or #40635
Closed

[Filebeat] Netflow input - disable event normalization #37764

andrewkroh opened this issue Jan 26, 2024 · 5 comments · Fixed by #37901 or #40635
Assignees
Labels
enhancement Filebeat Filebeat Team:Security-Deployment and Devices Deployment and Devices Team in Security Solution

Comments

@andrewkroh
Copy link
Member

andrewkroh commented Jan 26, 2024

Describe the enhancement:

Disable Beat event normalization for the input. Event normalization should not be needed for the input because it only uses basic types in its events. This will save CPU time for each event that is Publish()ed.

Example:

client, err := pipeline.ConnectWith(beat.ClientConfig{
CloseRef: inputContext.Cancelation,
EventListener: awscommon.NewEventACKHandler(),
Processing: beat.ProcessingConfig{
// This input only produces events with basic types so normalization
// is not required.
EventNormalization: boolPtr(false),
},
})

Describe a specific use case for the enhancement or feature:

This will marginally speed up the input's processing times (like 2%).

Related Issues

@andrewkroh andrewkroh added enhancement Filebeat Filebeat Team:Security-Deployment and Devices Deployment and Devices Team in Security Solution labels Jan 26, 2024
@pkoutsovasilis
Copy link
Contributor

hi @andrewkroh, please correct me if I am wrong, but to achieve disabling the EventNormalization first the netflow input needs to be migrated to plugin.v2 implementation right?

@andrewkroh
Copy link
Member Author

You're right. It does need to be using the v2 API. I forgot that we had inputs that haven't been migrated.

@pkoutsovasilis
Copy link
Contributor

thx for acknowledging my understanding @andrewkroh . I think that this issue should come first before #37762 and #37761 to get this first as a plugin v2 and then work our way through these

@andrewkroh
Copy link
Member Author

I created a separate issue for the conversion. #37865

@pkoutsovasilis
Copy link
Contributor

because of this issue event normalization has been re-enabled here for netflow. Thus, I am reopening this issue, to disable event normalization without any regressions 🙂

andrewkroh pushed a commit to elastic/go-structform that referenced this issue Jul 30, 2024
This fixes the encoding of types that derive from a primitive type, such as net.IP which derives from []byte.

Relates: elastic/beats#37764
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Filebeat Filebeat Team:Security-Deployment and Devices Deployment and Devices Team in Security Solution
Projects
None yet
2 participants