Heartbeat HTTP monitor should default to port 80 #3915
Comments
|
And it should default to 443 for HTTPS URLs. |
monicasarbu
pushed a commit
that referenced
this issue
Apr 10, 2017
* heartbeat: setup default ports in http monitors Default http to 80 and https to 443 Resolves #3915 * Add entry to changelog * Add test Also refactor the code, turns out net.SplitHostPort() doesn't like hosts without ports.
tsg
pushed a commit
that referenced
this issue
Apr 11, 2017
…tors (#3978) * heartbeat: setup default ports in http monitors Default http to 80 and https to 443 Resolves #3915 (cherry picked from commit c888f3f) * Add entry to changelog (cherry picked from commit aa40255) * Add test Also refactor the code, turns out net.SplitHostPort() doesn't like hosts without ports. (cherry picked from commit bd6898c) * Add newline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If port number is missing HTTP monitor loading fails with:
manager.go:125: ERR failed to load monitor tasks: missing port in address. The monitor should default to port 80, if no port is configured.The text was updated successfully, but these errors were encountered: