Use the .address fields for ambiguous address prior to extracting IP & domain #10141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
ruflin
approved these changes
Jan 17, 2019
|
Filebeat tests on both CI systems are hanging. I'll investigate this one some more. |
webmat
force-pushed
the
ecs-ambiguous-address
branch
2 times, most recently
from
f2e5893 to
5ac0c1c
Compare
added 5 commits
January 17, 2019 21:14
Note that I'm modifying the grok because the only thing expected in this field is either an IP or a socket path (e.g. for admin socket). And ECS doesn't define a place for socket paths in src/dst. IPs are never resolved to hostnames in HAProxy.
Can't actually get an error message for these timeouts, even when reproducing locally. Out of ideas. This reverts commit a78ebeb419cfa162551891846d35ba22c0bf8757.
webmat
force-pushed
the
ecs-ambiguous-address
branch
from
e022bb6 to
3bd8fd5
Compare
|
@webmat Please ignore the Jenkins CI for now. |
added 2 commits
January 18, 2019 12:30
- apache2.access.remote_ip points to source.address - apache.access.remote_ip is simply removed, since it was never publicly released My problems initially were caused by an alias pointing to an alias (apache2.access.remote_ip => apache.access.remote_ip => source.address)
|
Pretty sure I found my problem with CI, and it was legit. I was simply aliasing The alias is now directly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migration has been done in a few modules already. This completes the transition for the modules transitioned prior to ECS 1.0.0 Beta 2.
Modules/filesets affected
apache2.access.remote_ip)haproxy.client.ip)Noticed
HAProxy was migrated prior to ECS Beta 2. A few more fields should be migrated, opened #10143 for this.