Remove parsed timestamps from suricata events #10336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These dates fail to parse after recent changes in Elasticsearch for date formatting, see elastic/elasticsearch#36363 Information is still stored in parsed ECS fields.
|
Pinging @elastic/secops |
jsoriano
commented
Jan 25, 2019
| } | ||
| } | ||
| , {"remove": | ||
| {"field": "suricata.eve.flow.end" |
There was a problem hiding this comment.
Should this be used for event.end? @timestamp is used for that now.
jsoriano
commented
Jan 25, 2019
| @@ -53,7 +53,6 @@ | |||
| "suricata.eve.flow.bytes_toserver": 347, | |||
| "suricata.eve.flow.pkts_toclient": 3, | |||
| "suricata.eve.flow.pkts_toserver": 4, | |||
| "suricata.eve.flow.start": "2018-10-03T14:42:44.613469+0000", | |||
There was a problem hiding this comment.
I haven't removed these fields from fields.yml in case we want to reserve them to be used in the future. Happy to remove them in any case if we decide to go on this way.
|
Ok, merging by now to get CI green. |
|
@ruflin yes, my plan was to start today with the aliases 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These timestamps fail to parse after recent changes in Elasticsearch for date
formatting, see elastic/elasticsearch#36363
Information is still stored in parsed ECS fields.