[docs][APM] Add apm_user role #10683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simitt
reviewed
Feb 14, 2019
|
@simitt - your idea worked perfectly! This solution is so much cleaner than the previous. Thank you |
|
Just a FYI that I'm planning to do a significant rewrite of the security topic. My proposal is here (feel free to comment and add details for APM): #10241 (comment) |
|
@bmorelli25 it would be great if the issue elastic/apm-server#1579 could also be considered in the APM specific part of the security topic rewrite. |
|
@dedemorton I know there's going to be a re-write soon, but I'm wondering if we can merge this PR in the meantime? It would be nice to have some documentation on this new role live. |
dedemorton
approved these changes
Feb 25, 2019
|
Just did one final double check to make sure everything looks good for Beats and APM Server - and it does! Merging now... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the new reserved roll
apm_userto the documentation. See elastic/elasticsearch#38206 for more details.A few things:
apm_user) complicates things a lot. The documentation refers to a user as both the user and the role. To clarify, I swapped the use of user for account where applicable.The(fixed by simitt here){beatname}_readerexample no longer applies to APM. I cut this step out, but it meant I had to introduce a new attribute for this page called:role_name:. This maintains the use of "reader" for the beats examples, but swaps to "user" for the APM example.