[Auditbeat] Cherry-pick #10897 to 7.0: System module: Fix and unify bucket closing logic #11027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c#10897) The `host` dataset is erroneously trying to save state in its `Close()` method. It should have saved the state earlier - usually at the end of `Fetch()` - and then should only close the bucket (something it is not doing at all). At the same time, it is not saving state in its `reportState()` method. Combined, this can lead to an error when the dataset is terminated before the first regular `reportChanges()` is run. This fixes both issues and furthermore unifies the bucket closing logic across all six datasets of the System module. (cherry picked from commit e007c9c)
cwurm
changed the title
|
Pinging @elastic/secops |
adriansr
approved these changes
Mar 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #10897 to 7.0 branch. Original message:
The
hostdataset is erroneously trying to save state in itsClose()method. It should have saved the state earlier - usually at the end ofFetch()- and then should only close the bucket (something it is not doing at all). At the same time, it is not saving state in itsreportState()method. Combined, this can lead to an error when the dataset is terminated before the first regularreportChanges()is run.This fixes both issues and furthermore unifies the bucket closing logic across all six datasets of the System module.