Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mesos module to Metricbeat #11410

Closed
wants to merge 1 commit into from

Conversation

berfinsari
Copy link
Contributor

@berfinsari berfinsari commented Mar 23, 2019

No description provided.

@berfinsari berfinsari requested review from a team as code owners March 23, 2019 21:29
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@ruflin ruflin added discuss Issue needs further discussion. review Metricbeat Metricbeat Team:Integrations Label for the Integrations team module labels Mar 25, 2019
@ruflin
Copy link
Contributor

ruflin commented Mar 28, 2019

Hi @berfinsari . We discussed the Mesos module a bit internally. Our current problem is that we don't feel very comfortable yet to support it as we lack the knowledge around mesos and resources internally as the focus is currently on a few other big modules.

As usual, your contribution is of high quality and it would be great to still get this code out there. I'm wondering if you potentially could put this into a mesosbeat (in case it doesn't exist yet) so community members can already start to use it and we get some feedback on it?

@ruflin ruflin removed the review label Apr 8, 2019
@berfinsari
Copy link
Contributor Author

Thanks for the review! @ruflin .
I created mesosbeat #12185 . So We can talk again for mesos module with regard to the feedback we will have.

@ruflin
Copy link
Contributor

ruflin commented May 16, 2019

@berfinsari Great, thanks a lot. See my comment there about having it as still a module in a Beat. The advantage is that the output format would look identical as inside the Beat, so a later transition would be seamless.

Are you ok if we close this PR for now?

@berfinsari
Copy link
Contributor Author

Thanks, @ruflin.
I am okay to close Mesos PR for now. I updated the Mesosbeat to beat based on Metricbeat so after the feedback, I am willing to contribute Mesos module.

@berfinsari berfinsari closed this Sep 7, 2019
@ruflin
Copy link
Contributor

ruflin commented Sep 9, 2019

@berfinsari Thanks for all your work.

@exekias @andresrc FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Issue needs further discussion. Metricbeat Metricbeat module Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants