Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nfs: enforce unique ILLEGAL opname when failed to match operation #11503

Merged
merged 2 commits into from
Apr 30, 2019
Merged

nfs: enforce unique ILLEGAL opname when failed to match operation #11503

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f75b108
nfs: enforce unique ILLEGEL opname when failed to match operation
kofemann Mar 28, 2019
0451a4e
Add PR number to CHANGELOG
adriansr Apr 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.next.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ https://github.com/elastic/beats/compare/v7.0.0-alpha2...master[Check the HEAD d
*Packetbeat*

- Add support for mongodb opcode 2013 (OP_MSG). {issue}6191[6191] {pull}8594[8594]
- NFSv4: Always use opname `ILLEGAL` when failed to match request to a valid nfs operation. {pull}11503[11503]

*Winlogbeat*

Expand Down
4 changes: 1 addition & 3 deletions packetbeat/protos/nfs/nfs4.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@

package nfs

import "fmt"

const (
opAccess = 3
opClose = 4
Expand Down Expand Up @@ -234,7 +232,7 @@ func (nfs *nfs) findV4MainOpcode(xdr *xdr) string {
opname, ok := nfsOpnum4[op]

if !ok {
return fmt.Sprintf("ILLEGAL (%d)", op)
return "ILLEGAL"
}
currentOpname = opname

Expand Down