[Metricbeat] Migrate ceph to reporter V2 with error handling #11979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fearful-symmetry
added
Metricbeat
jsoriano
reviewed
Apr 30, 2019
| pgStateInfo = events[4].MetricSetFields["pg_state"].(common.MapStr) | ||
| assert.EqualValues(t, "active+undersized+degraded+remapped", pgStateInfo["state_name"]) | ||
| assert.EqualValues(t, 55, pgStateInfo["count"]) | ||
| assert.EqualValues(t, 813, pgStateInfo["version"]) |
|
jenkins, test this |
| m.Logger().Error(err) | ||
| reporter.Error(err) | ||
| return | ||
| return errors.Wrap(err, "error in mapping") | ||
| } | ||
|
|
||
| for _, event := range events { | ||
| reporter.Event(mb.Event{MetricSetFields: event}) |
There was a problem hiding this comment.
Add if !reported { return nil } check to be consistent with https://github.com/elastic/beats/pull/11979/files#diff-dc97d499b303003462f444c7164c2780R78?
kaiyan-sheng
approved these changes
May 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #11374
This one is a tad large, as I took the time to add comments and change variable names in order to make the linters happy.