Abort delayed stop autodiscover events on docker restart #13127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoriano
added
bug
review
libbeat
containers
If a container is being restarted and `close_timeout` is greater than zero (as is by default), the stop event may arrive after the new start, what stops resources started for the container. This change aborts the scheduled stops if the same container is started during the grace period.
jsoriano
force-pushed
the
docker-autodiscover-restart
branch
from
97b41cf to
e21f2c8
Compare
jsoriano
added
v7.3.1
needs_backport
|
Not sure about backporting this, as it slightly changes the behaviour. |
kaiyan-sheng
reviewed
Aug 5, 2019
kaiyan-sheng
approved these changes
Aug 13, 2019
|
jenkins, test this again |
|
I saw this cool implementation just now, did you consider doing the same for the Kubernetes provider? it would solve the same issues? |
I don't think that these issues can happen with Kubernetes. Stop events in Kubernetes are caused by destroyed pods, that cannot be restarted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a container is being restarted and
cleanup_timeoutis greater thanzero (as is by default), the stop event may arrive after the new start,
what stops resources started for the container. This change aborts the
scheduled stops if the same container is started during the grace
period.
cleanup_timeoutwas added on #10905, in 7.0, and disabled by default in 6.7.Fix #12962.