-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Uptime] Add docs for autodiscover hints #14252
Conversation
Autodiscover hints were introduced in elastic#13119 but not documented. This adds the docs. Resolves elastic#14245
Pinging @elastic/uptime (:uptime) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor changes. I'm assuming you built the files and verified the HTML output (don't have time to do that right now, but I don't want to block you).
|
||
As an example let's convert the regular syntax heartbeat monitors below into autodiscover hints. | ||
|
||
```yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use asciidoctor source code block formatting with syntax highlighting here (what you have here is Markdown). See https://asciidoctor.org/docs/asciidoc-syntax-quick-reference/#source-code
Co-Authored-By: Justin Kambic <[email protected]>
Co-Authored-By: DeDe Morton <[email protected]>
@dedemorton I've made all the changes you requested and tested locally. |
@Jenkins retest this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Caught a few more minor issues. Sorry I didn't catch these the first time around.
Co-Authored-By: DeDe Morton <[email protected]>
Co-Authored-By: DeDe Morton <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doc changes LGTM
Autodiscover hints were introduced in elastic#13119 but not documented. This adds the docs. Resolves elastic#14245 (cherry picked from commit 4eb1711)
Autodiscover hints were introduced in elastic#13119 but not documented. This adds the docs. Resolves elastic#14245 (cherry picked from commit 4eb1711)
Autodiscover hints were introduced in elastic#13119 but not documented. This adds the docs. Resolves elastic#14245
Autodiscover hints were introduced in #13119 but not documented. This adds the docs.
Resolves #14245