Fix cleanup when autodiscover pods are terminated #14259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases pods termination doesn't originate a delete event in the API watchers. Detect termination also by checking if a deletion timestamp exists in update events.
jsoriano
added
needs_backport
|
Similar change will be needed in |
|
Added changes to |
exekias
approved these changes
Oct 28, 2019
|
very good catch here @jsoriano! |
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Oct 28, 2019
In some cases pods termination doesn't originate a delete event in the API watchers. Detect termination also by checking if a deletion timestamp exists in update events. (cherry picked from commit 1c36118)
jsoriano
removed
the
needs_backport
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Oct 28, 2019
In some cases pods termination doesn't originate a delete event in the API watchers. Detect termination also by checking if a deletion timestamp exists in update events. (cherry picked from commit 1c36118)
This was referenced Oct 28, 2019
jsoriano
added a commit
that referenced
this pull request
Nov 5, 2019
jorgemarey
pushed a commit
to jorgemarey/beats
that referenced
this pull request
Jun 8, 2020
In some cases pods termination doesn't originate a delete event in the API watchers. Detect termination also by checking if a deletion timestamp exists in update events.
This was referenced Jul 21, 2020
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…are terminated (elastic#14265) In some cases pods termination doesn't originate a delete event in the API watchers. Detect termination also by checking if a deletion timestamp exists in update events. (cherry picked from commit 9de0061)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…astic#14268) In some cases pods termination doesn't originate a delete event in the API watchers. Detect termination also by checking if a deletion timestamp exists in update events. (cherry picked from commit 9de0061)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases pods termination doesn't originate a delete event in the
API watchers. Detect termination also by checking if a deletion
timestamp exists in update events.