Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metricbeat] [AWS] Add DynamoDB AWS light module #15097

Merged
merged 13 commits into from
Jan 14, 2020
Merged

[Metricbeat] [AWS] Add DynamoDB AWS light module #15097

merged 13 commits into from
Jan 14, 2020

Conversation

ChrsMark
Copy link
Member

@ChrsMark ChrsMark commented Dec 13, 2019 •
edited
Loading

This PR implements DynamoDB AWS metricbeat Module of #14856

Reference: https://docs.aws.amazon.com/amazondynamodb/latest/developerguide/metrics-dimensions.html

Dashboard:
Screenshot 2020-01-08 at 12 10 39

Manual Testing

  1. Enable aws module
  2. Use the following configuration:
- module: aws
  period: 60s
  metricsets:
    - dynamodb
  credential_profile_name: metricbeat
  regions:
    - eu-central-1
  1. Start Metricbeat
  2. Check that events are sent to ES or any other output.
    Notes:
  3. This requires an AWS account with DynamoDB features
  4. In order to automatically populate realistic data in AWS, DM author for instructions.

@ChrsMark ChrsMark added in progress Pull request is currently in progress. module Metricbeat Metricbeat [zube]: In Progress Team:Integrations Label for the Integrations team labels Dec 13, 2019
@ChrsMark ChrsMark self-assigned this Dec 13, 2019
@ChrsMark
Add more metrics
b9d46d9 
Signed-off-by: chrismark <[email protected]>
@ChrsMark ChrsMark marked this pull request as ready for review December 16, 2019 13:06
@ChrsMark ChrsMark requested a review from a team as a code owner December 16, 2019 13:06
@kaiyan-sheng kaiyan-sheng self-requested a review December 16, 2019 14:26
kaiyan-sheng
kaiyan-sheng reviewed Dec 16, 2019
View reviewed changes
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

x-pack/metricbeat/module/aws/dynamodb/_meta/data.json seems to be empty?

@ChrsMark
Add data.json
f873617 
Signed-off-by: chrismark <[email protected]>
@ChrsMark
Add dashboard
9612d75 
Signed-off-by: chrismark <[email protected]>
@ChrsMark ChrsMark removed the in progress Pull request is currently in progress. label Dec 17, 2019
kaiyan-sheng
kaiyan-sheng reviewed Dec 18, 2019
View reviewed changes
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice dashboard 👍 How about adding filters for regions and account name in the dashboard?

@ChrsMark
Add dashboard filters
ce0debf 
Signed-off-by: chrismark <[email protected]>
@ChrsMark ChrsMark requested a review from kaiyan-sheng January 8, 2020 10:17
@ChrsMark
Copy link
Member Author

ChrsMark commented Jan 8, 2020 •
edited
Loading

Nice dashboard 👍 How about adding filters for regions and account name in the dashboard?

Hey @kaiyan-sheng ! I updated the dashboard with the filters! Thanks for the suggestion!

kaiyan-sheng
kaiyan-sheng reviewed Jan 9, 2020
View reviewed changes
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait on this till #15245 get merged. Also could you add a changelog please? Thanks!

@ChrsMark ChrsMark requested a review from kaiyan-sheng January 10, 2020 11:24
@ChrsMark
Copy link
Member Author

@kaiyan-sheng this is updated now.

@ChrsMark
Add changelog
a14946a 
Signed-off-by: chrismark <[email protected]>
@ChrsMark
Fix docs
b5c07b5 
Signed-off-by: chrismark <[email protected]>
kaiyan-sheng
kaiyan-sheng approved these changes Jan 13, 2020
View reviewed changes
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good besides the conflict 😬 Thanks for working on this!

@ChrsMark ChrsMark added the needs_backport PR is waiting to be backported to other branches. label Jan 14, 2020
@ChrsMark ChrsMark merged commit 1bc8164 into elastic:master Jan 14, 2020
@ChrsMark ChrsMark added [zube]: In Review test-plan Add this PR to be manual test plan v7.7.0 and removed [zube]: Done labels Jan 14, 2020
ChrsMark added a commit to ChrsMark/beats that referenced this pull request Jan 16, 2020
@ChrsMark
[Metricbeat] [AWS] Add DynamoDB AWS light module (elastic#15097)
d4788a2 
(cherry picked from commit 1bc8164)
@ChrsMark ChrsMark mentioned this pull request Jan 16, 2020
Merged
@ChrsMark ChrsMark removed the needs_backport PR is waiting to be backported to other branches. label Jan 16, 2020
ChrsMark added a commit that referenced this pull request Jan 17, 2020
@ChrsMark
[Metricbeat] [AWS] Add DynamoDB AWS light module (#15097) (#15614)
8425cf0 
(cherry picked from commit 1bc8164)
@andresrc andresrc added the test-plan-added This PR has been added to the test plan label Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

Assignees

@ChrsMark ChrsMark

Labels
Metricbeat Metricbeat module review Team:Integrations Label for the Integrations team test-plan Add this PR to be manual test plan test-plan-added This PR has been added to the test plan v7.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChrsMark @kaiyan-sheng @andresrc