Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metricbeat] Implement IBM MQ module #15301
[Metricbeat] Implement IBM MQ module #15301
Changes from all commits
ddbe72a
2927d58
bcc0335
fc08998
647eaec
4783ce5
d6f5157
beecde6
3199185
f33456a
0727984
9266e67
6278515
1d8f0a8
8f41408
6715f09
7297ccd
216959d
30d63e5
d736e55
f28b213
c27a577
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we know which versions of MQ provide the exporter? Do we know how to enable it when not using the Docker image? I'm thinking on how feasible / easy is to go this route in real world deployments (/cc @felix-lessoer @exekias )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the questions, @andresrc . Let me respond to these:
The exporter is available only if you're using the image. It's part of the
runmqserver
, an application supported running in containerized environments.The description of the internals is available here: https://github.com/ibm-messaging/mq-container/blob/master/docs/internals.md
Source (main.go) of
runmqserver
: https://github.com/ibm-messaging/mq-container/blob/master/cmd/runmqserver/main.goNot specifically MQ, but the containerized distribution of it. According to the sources, the metrics exporter has been enabled in the release version 9.1.0.
Source code: https://github.com/ibm-messaging/mq-container/tree/9.1.0/internal/metrics
PR: https://github.com/ibm-messaging/mq-container/pull/81/files
I think that we can leave a message here that Metricbeat only supports deployments of the official containerized distribution of the MQ. Currently it's the only way to go if we don't want to link the proprietary code.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a short comment/description here of why we decided to use js processor here could be of worth
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added!