Split global and normal logger tests #15700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move logp global functions to global.go and selective.go, plus split up tests. The change also adds the `nologpglobal` build tag to global.go and global_test.go. By default all global functions are available. When compiling or running a package its test code with `-tags=nologpglobal`, then global logp functions are not available.
66 tasks
urso
commented
Jan 21, 2020
| assert.Equal(t, "", logs[0].LoggerName) | ||
| assert.Equal(t, "critical", logs[0].Message) | ||
| } | ||
| } |
There was a problem hiding this comment.
tests have been moved to global_test.go
urso
commented
Jan 21, 2020
| @@ -166,47 +93,6 @@ func TestLoggerLevel(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestRecover(t *testing.T) { | |||
There was a problem hiding this comment.
tests have been moved to global_test.go
urso
commented
Jan 21, 2020
| assert.False(t, HasSelector("publish")) | ||
| } | ||
|
|
||
| func TestIsDebug(t *testing.T) { |
There was a problem hiding this comment.
tests have been moved to global_test.go
urso
commented
Jan 21, 2020
| panic(cause) | ||
| } | ||
|
|
||
| func TestHasSelector(t *testing.T) { |
There was a problem hiding this comment.
test has been moved to selective_test.go
faec
approved these changes
Jan 23, 2020
| @@ -203,6 +205,14 @@ func (l *Logger) DPanicw(msg string, keysAndValues ...interface{}) { | |||
| l.sugar.DPanicw(msg, keysAndValues...) | |||
| } | |||
|
|
|||
| // Recover stops a panicking goroutine and logs an Error. | |||
| func (l *Logger) Recover(msg string) { | |||
There was a problem hiding this comment.
It doesn't look like this is called anywhere yet (including tests), should it be? Or is it just for use in followups?
kvch
approved these changes
Jan 24, 2020
2 tasks
urso
pushed a commit
to urso/beats
that referenced
this pull request
Jan 28, 2020
Move logp global functions to global.go and selective.go, plus split up tests. The change also adds the `nologpglobal` build tag to global.go and global_test.go. By default all global functions are available. When compiling or running a package its test code with `-tags=nologpglobal`, then global logp functions are not available. (cherry picked from commit 4183ba3)
urso
pushed a commit
that referenced
this pull request
Jan 28, 2020
Move logp global functions to global.go and selective.go, plus split up tests. The change also adds the `nologpglobal` build tag to global.go and global_test.go. By default all global functions are available. When compiling or running a package its test code with `-tags=nologpglobal`, then global logp functions are not available. (cherry picked from commit 4183ba3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Move logp global functions to global.go and selective.go, plus split up
tests. The change also adds the
nologpglobalbuild tag to global.go and global_test.go.By default all global functions are available. When compiling or
running a package its test code with
-tags=nologpglobal, then globallogp functions are not available.
Why is it important?
In order to better support structured logging in Beats we want to remove global logging functions. See #15699
This PR adds a build tag that can be used to check for packages that need to be cleaned up. When running
go build -tags=nologpglobalorgo test -tags=nologpglobalon a selected package, the compiler will fail until the package and its transitive dependencies have been cleaned up.Checklist
- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature worksAuthor's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs