Reduce global logging in some docker/k8s + AD related packages #16003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urso
added
in progress
66 tasks
kvch
reviewed
Feb 3, 2020
urso
added
[zube]: In Review
review
and removed
in progress
kvch
approved these changes
Feb 4, 2020
Merged
1 task
urso
pushed a commit
to urso/beats
that referenced
this pull request
Feb 4, 2020
…ic#16003) * Reduce global logging in some docker/k8s + AD related packages Reduce/Remove usage of global logging functions in docker and kubernetes related processors and Autodiscovery providers. The change adds the structured logging field `libbeat.processor: <name>` to the `add_kubernetes_metadata` and `add_docker_metadata` processors. Structured logging is transitive. Error/debug logs produced by the `libbeat/common/docker`, and `libbeat/common/kubernetes` packages will also mention the processor name. (cherry picked from commit bc71069)
urso
pushed a commit
that referenced
this pull request
Feb 5, 2020
* Reduce global logging in some docker/k8s + AD related packages Reduce/Remove usage of global logging functions in docker and kubernetes related processors and Autodiscovery providers. The change adds the structured logging field `libbeat.processor: <name>` to the `add_kubernetes_metadata` and `add_docker_metadata` processors. Structured logging is transitive. Error/debug logs produced by the `libbeat/common/docker`, and `libbeat/common/kubernetes` packages will also mention the processor name. (cherry picked from commit bc71069)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Reduce/Remove usage of global logging functions in docker and kubernetes related processors and Autodiscovery providers.
The change adds the structured logging field
libbeat.processor: <name>to theadd_kubernetes_metadataandadd_docker_metadataprocessors. Structured logging is transitive. Error/debug logs produced by thelibbeat/common/docker, andlibbeat/common/kubernetespackages will also mention the processor name.Why is it important?
Remove usage of global logging functions and improved structured logging support.
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature worksAuthor's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs