Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cisco.asciidoc #16131

Closed
wants to merge 1 commit into from
Closed

Update cisco.asciidoc #16131

wants to merge 1 commit into from

Conversation

loekvangool
Copy link

Making Elasticsearch explicit in the instructions

What does this PR do?

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

Making Elasticsearch explicit in the instructions
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @loekvangool, this file is generated so your change shouldn't be in this file. Could you make the same change in x-pack/filebeat/module/cisco/_meta/docs.asciidoc please? Then you can run mage update under x-pack/filebeat. That should update the generated file. Thanks!

@loekvangool
Copy link
Author

@kaiyan-sheng alright but please keep in mind there is an "Edit" button for Elasticians in our docs and its lead me to create the PR against this file. So perhaps that could be improved so folks from other teams can easily submit document PRs @zuketo

@kaiyan-sheng kaiyan-sheng added docs needs_backport PR is waiting to be backported to other branches. review labels Feb 10, 2020
@dedemorton
Copy link
Contributor

dedemorton commented Feb 19, 2020

Hi. I can take care of getting this backported and running the update. Thanks!

@dedemorton
Copy link
Contributor

I couldn't get make update to work on this branch (due to recent dev environment changes in master). So I cherry-picked this change into another PR and ran make update: #16434.

@dedemorton dedemorton closed this Feb 19, 2020
@dedemorton dedemorton removed the needs_backport PR is waiting to be backported to other branches. label Feb 19, 2020
@dedemorton dedemorton deleted the loekvangool-patch-1 branch February 19, 2020 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants