Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #16275 to 7.x: Fix disk used visualization in system host overview dashboard #16550

Merged
merged 1 commit into from
Feb 27, 2020

Conversation

exekias
Copy link
Contributor

@exekias exekias commented Feb 25, 2020

Cherry-pick of PR #16275 to 7.x branch. Original message:

What does this PR do?

This change updates the Disk Used to honor default collecting period
for fsstat metricset (1m). Visualization sets the query to >=1m to
make sure we get a big enough bucket size when querying fsstat metrics.

image

Why is it important?

Without this change the host overview dashboard may or may not show the correct value for used disk.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Related issues

…c#16275)

* Fix disk used visualization in system host overview dashboard

This change updates the `Disk Used` to honor default collecting period
for `fsstat` metricset (1m). Visualization sets the query to `>=1m` to
make sure we get a big enough bucket size when querying fsstat metrics.

* Put `CHANGEME_HOSTNAME` back in the dashboard

(cherry picked from commit b0c600a)
@exekias exekias requested a review from a team as a code owner February 25, 2020 11:15
Copy link
Contributor

@narph narph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@exekias exekias merged commit 267f1b3 into elastic:7.x Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants