Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rerun mage fmt update for metricbeat #16698

Merged
merged 1 commit into from
Feb 29, 2020
Merged

Rerun mage fmt update for metricbeat #16698

merged 1 commit into from
Feb 29, 2020

Conversation

kaiyan-sheng
Copy link
Contributor

CI is failing because Error: some files are not up-to-date. Run 'mage fmt update' then review and commit the changes. Modified: [metricbeat/docs/modules/haproxy.asciidoc]

@kaiyan-sheng kaiyan-sheng self-assigned this Feb 28, 2020
@kaiyan-sheng kaiyan-sheng added needs_backport PR is waiting to be backported to other branches. review Team:Integrations Label for the Integrations team labels Feb 28, 2020
Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@kaiyan-sheng
Copy link
Contributor Author

CI still failing because of a separate issue:

--- FAIL: TestFetch (90.45s)
    node_integration_test.go:37: 
        	Error Trace:	node_integration_test.go:37
        	Error:      	Should NOT be empty, but was []
        	Test:       	TestFetch
panic: runtime error: index out of range [0] with length 0 [recovered]
	panic: runtime error: index out of range [0] with length 0
goroutine 21 [running]:
testing.tRunner.func1(0xc0000f9800)
	/usr/local/go/src/testing/testing.go:874 +0x3a3
panic(0xdbe480, 0xc000305260)
	/usr/local/go/src/runtime/panic.go:679 +0x1b2
github.com/elastic/beats/x-pack/metricbeat/module/redisenterprise/node.TestFetch(0xc0000f9800)
	/go/src/github.com/elastic/beats/x-pack/metricbeat/module/redisenterprise/node/node_integration_test.go:38 +0x6fc
testing.tRunner(0xc0000f9800, 0xe3fda0)
	/usr/local/go/src/testing/testing.go:909 +0xc9
created by testing.(*T).Run
	/usr/local/go/src/testing/testing.go:960 +0x350
FAIL	github.com/elastic/beats/x-pack/metricbeat/module/redisenterprise/node	90.461s
=== RUN   TestFetch
--- FAIL: TestFetch (89.06s)
    proxy_integration_test.go:37: 
        	Error Trace:	proxy_integration_test.go:37
        	Error:      	Should NOT be empty, but was []
        	Test:       	TestFetch
panic: runtime error: index out of range [0] with length 0 [recovered]
	panic: runtime error: index out of range [0] with length 0
goroutine 8 [running]:
testing.tRunner.func1(0xc0000d5800)
	/usr/local/go/src/testing/testing.go:874 +0x3a3
panic(0xdbe480, 0xc0002fe980)
	/usr/local/go/src/runtime/panic.go:679 +0x1b2
github.com/elastic/beats/x-pack/metricbeat/module/redisenterprise/proxy.TestFetch(0xc0000d5800)
	/go/src/github.com/elastic/beats/x-pack/metricbeat/module/redisenterprise/proxy/proxy_integration_test.go:38 +0x6fc
testing.tRunner(0xc0000d5800, 0xe3fda8)
	/usr/local/go/src/testing/testing.go:909 +0xc9
created by testing.(*T).Run
	/usr/local/go/src/testing/testing.go:960 +0x350
FAIL	github.com/elastic/beats/x-pack/metricbeat/module/redisenterprise/proxy	89.080s
FAIL
FAILURES:
Package: github.com/elastic/beats/x-pack/metricbeat/module/redisenterprise/node
Test:    TestFetch
Error Trace:	proxy_integration_test.go:37
panic: runtime error: index out of range [0] with length 0 [recovered]

@kaiyan-sheng kaiyan-sheng merged commit 0d9bd4f into elastic:master Feb 29, 2020
@kaiyan-sheng kaiyan-sheng deleted the rerun_mage branch February 29, 2020 00:19
@kaiyan-sheng kaiyan-sheng removed the needs_backport PR is waiting to be backported to other branches. label Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants