Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Libbeat] Add v7 into libbeat/logp when importing #16764

Merged
merged 1 commit into from
Mar 3, 2020
Merged

[Libbeat] Add v7 into libbeat/logp when importing #16764

merged 1 commit into from
Mar 3, 2020

Conversation

kaiyan-sheng
Copy link
Contributor

This PR is to fix problem caused by adding version when importing libbeat/logp.

(python-env) kaiyansheng@KaiyanMacBookPro:~/go/src/github.com/elastic/beats/libbeat/processors/actions (fix_logp)$ go vet ./...
# github.com/elastic/beats/v7/libbeat/processors/actions
vet: ./rename_test.go:240:13: cannot use log (variable of type *logp.Logger) as *logp.Logger value in struct literal

@kaiyan-sheng kaiyan-sheng self-assigned this Mar 3, 2020
@blakerouse
Copy link
Contributor

lgtm!

@kaiyan-sheng kaiyan-sheng mentioned this pull request Mar 3, 2020
Closed
@kaiyan-sheng
Copy link
Contributor Author

CI is still broken but not related to this fix. Merging this PR.

@kaiyan-sheng kaiyan-sheng merged commit fff389b into elastic:7.x Mar 3, 2020
@kaiyan-sheng kaiyan-sheng deleted the fix_logp branch March 3, 2020 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakerouse blakerouse blakerouse approved these changes

Assignees

@kaiyan-sheng kaiyan-sheng

Labels
review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaiyan-sheng @blakerouse