Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metricbeat] Add vpc dashboard #16787

Closed
wants to merge 1 commit into from
Closed

[Metricbeat] Add vpc dashboard #16787

wants to merge 1 commit into from

Conversation

kaiyan-sheng
Copy link
Contributor

This PR is to add overview dashboard for vpc metricset in aws module.
I don't have good data points for VPCs so right now everything is zero in the screenshot.

Screen Shot 2020-03-03 at 9 01 08 PM

@kaiyan-sheng kaiyan-sheng requested a review from a team as a code owner March 4, 2020 04:01
@kaiyan-sheng kaiyan-sheng self-assigned this Mar 4, 2020
@kaiyan-sheng kaiyan-sheng added in progress Pull request is currently in progress. Metricbeat Metricbeat needs_backport PR is waiting to be backported to other branches. Team:Platforms Label for the Integrations - Platforms team labels Mar 4, 2020
mtojek
mtojek approved these changes Mar 13, 2020
View reviewed changes
Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I didn't say that... but in case you can't simulate real metric traffic, you can put some forged documents into ES :)

@mtojek
Copy link
Contributor

mtojek commented Mar 13, 2020

There is also some error reported by CI:

   expected index pattern reference 'metricbeat-*': unexpected reference to index pattern 99198ae0-5a46-11ea-9dd7-5195965709e4
   expected index pattern reference 'metricbeat-*': unexpected reference to index pattern 99198ae0-5a46-11ea-9dd7-5195965709e4

@kaiyan-sheng
Copy link
Contributor Author

@mtojek Totally! I'm actually doing that in #16892 for creating dashboards. I'm separating vpc metricset into 3 separate metricsets and will create 3 different dashboards as well. Will close this PR for now! Thanks for the suggestion.

@kaiyan-sheng kaiyan-sheng deleted the add_dashboard_vpc branch March 18, 2020 14:28
@kaiyan-sheng kaiyan-sheng removed the needs_backport PR is waiting to be backported to other branches. label Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtojek mtojek mtojek approved these changes

Assignees

@kaiyan-sheng kaiyan-sheng

Labels
in progress Pull request is currently in progress. Metricbeat Metricbeat Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaiyan-sheng @mtojek @andresrc