Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install mage and goimports from vendor folder #16836

Merged
merged 1 commit into from
Mar 6, 2020

Conversation

kvch
Copy link
Contributor

@kvch kvch commented Mar 5, 2020

What does this PR do?

This PR removes all outdated install paths from Makefiles.

Why is it important?

ATM running make fmt fails with the following error:

2020/03/05 13:47:25 exec: go list -m
2020/03/05 13:47:25 Found Elastic Beats dir at /Users/chrismark/go/src/github.com/elastic/beats
>> fmt - go-licenser: Adding missing headers
can't load package: package github.com/elastic/beats/vendor/golang.org/x/tools/cmd/goimports: cannot find package "." in:
	/Users/chrismark/go/src/github.com/elastic/beats/vendor/github.com/elastic/beats/vendor/golang.org/x/tools/cmd/goimports
make: *** [fmt] Error 1

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works

@kvch kvch added [zube]: In Review Team:Services (Deprecated) Label for the former Integrations-Services team labels Mar 5, 2020
@kvch kvch requested review from a team as code owners March 5, 2020 12:13
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

@kvch kvch merged commit e5322af into elastic:master Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Services (Deprecated) Label for the former Integrations-Services team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants