Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metricbeat] Remove error message when no metrics are collected from gcp #16916

Merged
merged 1 commit into from
Mar 10, 2020
Merged

[Metricbeat] Remove error message when no metrics are collected from gcp #16916

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions x-pack/metricbeat/module/googlecloud/stackdriver/metrics_requester.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,11 +109,6 @@ func (r *stackdriverMetricsRequester) Metrics(ctx context.Context, ms []string)
}

wg.Wait()

if len(results) == 0 {
return nil, errors.New("service returned 0 metrics")
}

return results, nil
}

Expand Down
1 change: 0 additions & 1 deletion x-pack/metricbeat/module/googlecloud/stackdriver/metricset.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,6 @@ func (m *MetricSet) Fetch(ctx context.Context, reporter mb.ReporterV2) (err erro

responses, err := reqs.Metrics(ctx, m.config.Metrics)
if err != nil {

return errors.Wrapf(err, "error trying to get metrics for project '%s' and zone '%s' or region '%s'", m.config.ProjectID, m.config.Zone, m.config.Region)
}

Expand Down