Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #16916 to 7.x: [Metricbeat] Remove error message when no metrics are collected from gcp #16924

Merged
merged 1 commit into from
Mar 10, 2020
Merged

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Mar 10, 2020

Cherry-pick of PR #16916 to 7.x branch. Original message:

What does this PR do?

This PR is to remove error message from Metricbeat when there is no metrics are collected from GCP.

Why is it important?

It's normal to not have any metrics when there is no instance in a specific region/zone. With the error message might actually confuse users.

closes #16882

@kaiyan-sheng kaiyan-sheng self-assigned this Mar 10, 2020
@andresrc andresrc added [zube]: Inbox Team:Platforms Label for the Integrations - Platforms team labels Mar 10, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@kaiyan-sheng kaiyan-sheng merged commit 5f51e67 into elastic:7.x Mar 10, 2020
@kaiyan-sheng kaiyan-sheng deleted the backport_16916_7.x branch March 10, 2020 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport review Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants