Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #16889 to 7.x: [Filebeat] Cisco FTD issues parsing Security Event messages #16981

Merged
merged 4 commits into from
Mar 19, 2020

Conversation

andrewstucki
Copy link

@andrewstucki andrewstucki commented Mar 12, 2020

Cherry-pick of PR #16889 to 7.x branch. Original message:

You'll want to take a look at this pr with ?w=1 since there was a lot of formatting changes for the pipeline.

What does this PR do?

Fixes a few bugs with the shared cisco parsing pipeline that was causing some fields to be dropped/misinterpreted

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Related issues

…16889)

* Fix grok and kv split bugs

* Fix optional whitespace for field name separator

(cherry picked from commit 912eac4)
@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@adriansr
Copy link
Contributor

I've realized we forgot to add a CHANGELOG entry for this fix. I suggest you add it to the backport PRs and then open a separate PR to fix master.

jsoriano
jsoriano previously approved these changes Mar 19, 2020
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this have had a changelog entry?

@jsoriano
Copy link
Member

I've realized we forgot to add a CHANGELOG entry for this fix. I suggest you add it to the backport PRs and then open a separate PR to fix master.

Oh sorry, I missed this comment 😅

@jsoriano jsoriano dismissed their stale review March 19, 2020 11:08

Waiting for changelog in backports as suggested by Adrian

adriansr
adriansr previously approved these changes Mar 19, 2020
@adriansr adriansr dismissed their stale review March 19, 2020 12:18

Forgot about changelog

Andrew Stucki added 3 commits March 19, 2020 13:56
@andrewstucki andrewstucki merged commit f951a29 into elastic:7.x Mar 19, 2020
@andrewstucki andrewstucki deleted the backport_16889_7.x branch March 19, 2020 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants