Improve Prometheus remote_write metricset docs #16997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chrismark <[email protected]>
ChrsMark
added
enhancement
docs
review
needs_backport
|
Pinging @elastic/integrations-platforms (Team:Platforms) |
exekias
reviewed
Mar 13, 2020
| tls_config: | ||
| cert_file: "/etc/prometheus/my_key.pem" | ||
| key_file: "/etc/prometheus/my_key.key" | ||
| insecure_skip_verify: true |
There was a problem hiding this comment.
I think it would make sense to comment this one out, and leave it as an example for the case when you cannot validate the host with a CA, WDYT?
Signed-off-by: chrismark <[email protected]>
exekias
approved these changes
Mar 16, 2020
ChrsMark
added a commit
to ChrsMark/beats
that referenced
this pull request
Mar 16, 2020
(cherry picked from commit 71b4116)
ChrsMark
removed
the
needs_backport
ChrsMark
added a commit
that referenced
this pull request
Mar 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up of #16609 to improve the docs of the metricset by: