Cherry-pick #17198 to 7.x: Update redis dependency as output #17234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit d5289fc)
ycombinator
reviewed
Mar 25, 2020
| @@ -23,7 +23,8 @@ output.redis: | |||
|
|
|||
| ==== Compatibility | |||
|
|
|||
| This output works with Redis 3.2.4. | |||
| This output is expected to work with all Redis versions between 5.0.8 and 3.2.4. Other versions might work as well, | |||
There was a problem hiding this comment.
I realize this is the backport PR which mirrors the PR to master, but any reason we listed the versions in this order? Ascending order seems more natural to me, but perhaps that's an English bias?
There was a problem hiding this comment.
I admit I missed it here, I will merge this PR and do another round of PRs to fix it.
ycombinator
approved these changes
Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #17198 to 7.x branch. Original message:
This PR verifies if
redisdependency can be updated, which means that thelibbeatoutput supported versions can be adjusted accordingly.