Cherry-pick #17300 to 7.7: Restore patched version of gopacket #17317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces github.com/google/gopacket with github.com/adriansr/gopacket which includes a fix to make af_packet work on 32bit x86. This patched version was already vendored but lost during the migration to Go modules. This patch is on review at google/gopacket#720 (cherry picked from commit 002b9c5)
|
Pinging @elastic/siem (Team:SIEM) |
andrewkroh
approved these changes
Apr 7, 2020
|
jenkins, test this |
1 similar comment
|
jenkins, test this |
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
This replaces github.com/google/gopacket with github.com/adriansr/gopacket which includes a fix to make af_packet work on 32bit x86. This patched version was already vendored but lost during the migration to Go modules. This patch is on review at google/gopacket#720 (cherry picked from commit 7a65724)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #17300 to 7.7 branch. Original message:
What does this PR do?
This replaces github.com/google/gopacket with github.com/adriansr/gopacket which includes a fix to make
af_packetwork on 32bit x86 platforms.This patched version was already vendored but lost during the migration to Go modules.
This patch is on review at google/gopacket#720 to hopefully get it merged upstream.
Why is it important?
This is necessary so that Auditbeat's system/socket works in 32bit Linux.
Checklist
My code follows the style guidelines of this projectI have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature worksI have added an entry in-> no changelog entry needed as this regression has not been released.CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues