Cherry-pick #17351 to 7.7: add_process_metadata: container id: Do not cache whole cgroup file for each process #17361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r each process (elastic#17351) * Do not cache whole cgroup file for each process. Include kube-proxy cid too. Co-authored-by: Jako Tinkus <[email protected]> (cherry picked from commit 8a47788)
kaiyan-sheng
approved these changes
Mar 31, 2020
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…r each process (elastic#17351) (elastic#17361) * Do not cache whole cgroup file for each process. Include kube-proxy cid too. Co-authored-by: Jako Tinkus <[email protected]> (cherry picked from commit 76f4353) Co-authored-by: jtinkus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #17351 to 7.7 branch. Original message:
What does this PR do?
Current solution caches whole content of cgroup file for each process. Let's cache only found container ids.
Also, current solution skips kube-proxy container processes, because cgroup path has suffix /kube-proxy.
Why is it important?
Caching such a pile of useless data has performance impact.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
How to test this PR locally
Related issues
Relates #15947
Use cases
Screenshots
Logs