Cherry-pick #17383 to 7.7: Remove dataType field of query metricset #17426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 495595d)
|
Pinging @elastic/integrations-platforms (Team:Platforms) |
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
(cherry picked from commit deba29e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #17383 to 7.7 branch. Original message:
What does this PR do?
This PRs moves
prometheus.query.dataTypefield toprometheus.labels.dataType.Why is it important?
prometheus.query.dataTypeis of type string however the mapping ofprometheus.query.*is for float values (and actually is used to store metrics). This makes it unable to index events in Elasticsearch. Hence,prometheus.query.dataTypeshould be moved under labels which are mapped as strings.closes #17401