-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix trivial conatiner typo in 6.8 #17570
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
💚 CLA has been signed |
It would be great to include this into 6.8.9 and release it asap |
Hey, good catch, This is solved in 7.x (#10525), but I think it was not backported to 6.8 because it was considered a breaking change, we use to avoid changing field names in patch versions. @kvch can know more about this specific issue. But the typo in documentation is still there in master, I think this should be fixed. @timp87 would you like to open a PR on master to fix the docs? Thanks! |
Pinging @elastic/integrations (Team:Integrations) |
Will 6.9 include the fix (if 6.9 will exist at all)? Just checked 7.6, 7.7, 7.x and master - they all have typo in journalbeat/docs/config-options.asciidoc. P. S. this tiny typo made me cry when I realized it was the root cause of my issue after 2 days of investigation. |
Found this when run journalbeat 6.8.8.
Well, probably 7.x and master have the same issue at least in config-options.asciidoc