Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trivial conatiner typo in 6.8 #17570

Closed
wants to merge 1 commit into from
Closed

Fix trivial conatiner typo in 6.8 #17570

wants to merge 1 commit into from

Conversation

timp87
Copy link

@timp87 timp87 commented Apr 7, 2020

Found this when run journalbeat 6.8.8.

Well, probably 7.x and master have the same issue at least in config-options.asciidoc

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

1 similar comment
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cla-checker-service
Copy link

cla-checker-service bot commented Apr 7, 2020

💚 CLA has been signed

@timp87
Copy link
Author

timp87 commented Apr 7, 2020

It would be great to include this into 6.8.9 and release it asap

@jsoriano
Copy link
Member

jsoriano commented Apr 8, 2020

Hey, good catch,

This is solved in 7.x (#10525), but I think it was not backported to 6.8 because it was considered a breaking change, we use to avoid changing field names in patch versions. @kvch can know more about this specific issue.

But the typo in documentation is still there in master, I think this should be fixed. @timp87 would you like to open a PR on master to fix the docs? Thanks!

@jsoriano jsoriano added [zube]: In Review discuss Issue needs further discussion. review Team:Integrations Label for the Integrations team labels Apr 8, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@timp87
Copy link
Author

timp87 commented Apr 8, 2020

Will 6.9 include the fix (if 6.9 will exist at all)?

Just checked 7.6, 7.7, 7.x and master - they all have typo in journalbeat/docs/config-options.asciidoc.
To be honest it's too trivial and I would prefer if you just fix that rather than me.

P. S. this tiny typo made me cry when I realized it was the root cause of my issue after 2 days of investigation.

@kvch
Copy link
Contributor

kvch commented Apr 9, 2020

@timp87 Sorry about your troubles. It is a breaking change, so I did not backport the fix to the 6.x major.

I opened a PR to fix the documentation issue: #17632

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Issue needs further discussion. review Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants