Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'print' and 'file' for python 3.5 scripts in libbeat #1778

Merged
merged 1 commit into from
Jun 1, 2016

Conversation

radoondas
Copy link
Member

This PR fixes (in my case) issues with python scripts. I was unable to run 'make update' unless I fixed scripts the way as in commit. Environment created in my beat was with python3.5.
Is this a valid fix?

@elasticsearch-release
Copy link

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'.

1 similar comment
@elasticsearch-release
Copy link

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'.

@radoondas radoondas changed the title Fix 'print' anf 'file' for python 3.5 scripts in libbeat Fix 'print' and 'file' for python 3.5 scripts in libbeat May 31, 2016
@ruflin
Copy link
Contributor

ruflin commented May 31, 2016

I think most of us running everything in Python 2.7.x. It would be nice if the above fixes make it compatible with both version. I will probably have to test this one manually :-)

@ruflin ruflin added the review label May 31, 2016
@radoondas
Copy link
Member Author

I thought so.
I still noticed that there were in one 'print' call parenthesis and in the other not. And the same with 'file' vs 'open' call. I will be happy if you test it when you have time. :)

@ruflin ruflin added the libbeat label Jun 1, 2016
@ruflin
Copy link
Contributor

ruflin commented Jun 1, 2016

Seems to work fine under python 2.7. Merging.

@ruflin ruflin merged commit 150e624 into elastic:master Jun 1, 2016
@radoondas radoondas deleted the python_script_fix branch June 28, 2018 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants