Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update communitybeats.asciidoc #1786

Merged
merged 2 commits into from
Jun 2, 2016
Merged

Update communitybeats.asciidoc #1786

merged 2 commits into from
Jun 2, 2016

Conversation

2Fast2BCn
Copy link
Contributor

I'm not sure if you would consider the "beat" complete. But the source code is working for me.

I'm not sure if you would consider the "beat" complete. But the source code is working for me.
@elasticsearch-release
Copy link

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'.

1 similar comment
@elasticsearch-release
Copy link

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'.

@ruflin
Copy link
Contributor

ruflin commented Jun 2, 2016

Hi @2Fast2BCn

Thanks a lot for the addition and creation of a beat. Could you insert the beat alphabetically sorted into the list? Would you mind signing the CLA? http://www.elasticsearch.org/contributor-agreement/

Perhaps this beat could also be a nice addition of a metricset to the redis module in metricbeat: https://github.com/elastic/beats/tree/master/metricbeat/module/nginx What do you think?

@2Fast2BCn
Copy link
Contributor Author

Yes, this all sounds good.
I changed the order.

@ruflin
Copy link
Contributor

ruflin commented Jun 2, 2016

LGTM. Let me know in case you need some help creating a MetricSet :-)

@ruflin ruflin merged commit 9c802fd into elastic:master Jun 2, 2016
@2Fast2BCn 2Fast2BCn deleted the patch-1 branch June 5, 2016 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants