Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #18172 to 7.x: [Metricbeat] Add dashboard for googlecloud storage metricset #18257

Merged
merged 1 commit into from
May 5, 2020
Merged

Cherry-pick #18172 to 7.x: [Metricbeat] Add dashboard for googlecloud storage metricset #18257

merged 1 commit into from
May 5, 2020

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented May 5, 2020

Cherry-pick of PR #18172 to 7.x branch. Original message:

What does this PR do?

This PR is to add dashboard for googlecloud storage metricset.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

  1. Make sure your GCP account for testing has storage buckets
  2. Enable googlecloud module: ./metricbeat modules enable googlecloud
  3. Edit modules.d/googlecloud.yml to:
- module: googlecloud
  metricsets:
    - storage
  project_id: "your project id"
  credentials_file_path: "your JSON credentials file path"
  exclude_labels: false
  period: 5m
  1. Start metricbeat: ./metricbeat -e
  2. Wait for 5 minutes and you should see data points in GCP storage dashboard.

Screenshots

metricbeat-googlecloud-storage-overview2

* add dashboard for googlecloud storage

(cherry picked from commit 8935545)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 5, 2020
@kaiyan-sheng kaiyan-sheng self-assigned this May 5, 2020
@kaiyan-sheng kaiyan-sheng added the Team:Platforms Label for the Integrations - Platforms team label May 5, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport LGTM.

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview stats

Expand to view the summary

Build stats

Test stats 🧪

Test Results
Failed 0
Passed 2323
Skipped 560
Total 2883

@kaiyan-sheng kaiyan-sheng merged commit c4f6b66 into elastic:7.x May 5, 2020
@kaiyan-sheng kaiyan-sheng deleted the backport_18172_7.x branch May 5, 2020 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport needs_team Indicates that the issue/PR needs a Team:* label review Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants