Remove global logp calls from libbeat/kibana and libbeat/template #18258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvch
added
[zube]: In Review
Team:Services
|
Pinging @elastic/integrations-services (Team:Services) |
botelastic
bot
added
the
needs_team
66 tasks
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
urso
reviewed
May 6, 2020
libbeat/kibana/client.go
Outdated
| @@ -271,7 +274,7 @@ func (client *Client) ImportJSON(url string, params url.Values, jsonBody map[str | |||
|
|
|||
| body, err := json.Marshal(jsonBody) | |||
| if err != nil { | |||
| logp.Err("Failed to json encode body (%v): %#v", err, jsonBody) | |||
| client.log.Errorf("Failed to json encode body (%v): %#v", err, jsonBody) | |||
There was a problem hiding this comment.
I wonder if this log is redundant. The error returned also contains the original error message. The jsonBody maybe we always want to log at debug level?
Would it make sense to add debug logs to other places? E.g. before and after a request is send?
There was a problem hiding this comment.
I've just run setup --dashboards with debug logging. It prints which dashboard it is loading and if there is an error it is logged, too. I think that should be enough.
kvch
force-pushed
the
refactoring-remove-logp-libbeat
branch
from
25eaa04 to
0f52f74
Compare
urso
approved these changes
May 7, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.